Remove support for experiemental dependency resolution (#43)

🎉
This commit is contained in:
Junegunn Choi 2014-07-30 19:52:19 +09:00
parent f58d090bb2
commit 30ef53d832
3 changed files with 79 additions and 151 deletions

View File

@ -16,7 +16,6 @@ Somewhere between [Pathogen](https://github.com/tpope/vim-pathogen) and
- Smallest possible feature set
- Branch/tag support
- On-demand loading
- Dependency resolution using `Plugfile` (experimental)
### Cons.
@ -163,15 +162,11 @@ let g:fzf_install = 'yes | ./install'
Plug 'junegunn/fzf', { 'do': g:fzf_install }
```
### Dependency resolution
See [Dependency
Resolution](https://github.com/junegunn/vim-plug/wiki/Dependency-Resolution).
### Articles
- [Writing my own Vim plugin manager](http://junegunn.kr/2013/09/writing-my-own-vim-plugin-manager)
- [Thoughts on Vim plugin dependency](http://junegunn.kr/2013/09/thoughts-on-vim-plugin-dependency)
- *Support for Plugfile has been removed since 0.5.0*
- [Vim plugins and startup time](http://junegunn.kr/2014/07/vim-plugins-and-startup-time)
### FAQ/Troubleshooting

View File

@ -66,7 +66,6 @@ let s:cpo_save = &cpo
set cpo&vim
let s:plug_source = 'https://raw.github.com/junegunn/vim-plug/master/plug.vim'
let s:plug_file = 'Plugfile'
let s:plug_buf = -1
let s:mac_gui = has('gui_macvim') && has('gui_running')
let s:is_win = has('win32') || has('win64')
@ -106,7 +105,7 @@ function! plug#begin(...)
" we want to keep track of the order plugins where registered.
let g:plugs_order = []
command! -nargs=+ -bar Plug call s:add(1, <args>)
command! -nargs=+ -bar Plug call s:add(<args>)
command! -nargs=* -complete=customlist,s:names PlugInstall call s:install(<f-args>)
command! -nargs=* -complete=customlist,s:names PlugUpdate call s:update(<f-args>)
command! -nargs=0 -bang PlugClean call s:clean('<bang>' == '!')
@ -125,12 +124,6 @@ function! plug#end()
if !exists('g:plugs')
return s:err('Call plug#begin() first')
endif
let keys = keys(g:plugs)
let plugfiles = s:find_plugfiles()
while !empty(keys)
" No need to look for Plugfiles more than once
let keys = keys(s:extend(keys, plugfiles))
endwhile
if exists('#PlugLOD')
augroup PlugLOD
@ -306,7 +299,7 @@ function! s:lod_map(map, name, prefix)
call feedkeys(a:prefix . substitute(a:map, '^<Plug>', "\<Plug>", '') . extra)
endfunction
function! s:add(force, repo, ...)
function! s:add(repo, ...)
if a:0 > 1
return s:err('Invalid number of arguments (1..2)')
endif
@ -314,17 +307,8 @@ function! s:add(force, repo, ...)
try
let repo = s:trim(a:repo)
let name = fnamemodify(repo, ':t:s?\.git$??')
if !a:force && has_key(g:plugs, name)
let s:extended[name] = g:plugs[name]
return
endif
let spec = extend(s:infer_properties(name, repo),
\ a:0 == 1 ? s:parse_options(a:1) : copy(s:base_spec))
if !a:force
let s:extended[name] = spec
endif
let g:plugs[name] = spec
let g:plugs_order += [name]
catch
@ -614,36 +598,6 @@ function! s:update_impl(pull, args) abort
call setline(1, 'Updated. Elapsed time: ' . split(reltimestr(reltime(st)))[0] . ' sec.')
endfunction
function! s:find_plugfiles()
let plugfiles = {}
for pf in split(globpath(g:plug_home, '*/'.s:plug_file), '\n')
let plugfiles[fnamemodify(pf, ':h:t')] = pf
endfor
return plugfiles
endfunction
function! s:extend(names, ...)
let s:extended = {}
let plugfiles = a:0 > 0 ? a:1 : s:find_plugfiles()
try
command! -nargs=+ Plug call s:add(0, <args>)
for name in a:names
let spec = g:plugs[name]
if spec.local
let plugfile = globpath(s:rtp(spec), s:plug_file)
if filereadable(plugfile)
execute 'source '. s:esc(plugfile)
endif
elseif has_key(plugfiles, name)
execute 'source '. s:esc(plugfiles[name])
endif
endfor
finally
command! -nargs=+ Plug call s:add(1, <args>)
endtry
return s:extended
endfunction
function! s:update_progress(pull, cnt, bar, total)
call setline(1, (a:pull ? 'Updating' : 'Installing').
\ ' plugins ('.a:cnt.'/'.a:total.')')
@ -659,7 +613,6 @@ function! s:update_serial(pull, todo)
let done = {}
let bar = ''
while !empty(todo)
for [name, spec] in items(todo)
let done[name] = 1
if isdirectory(spec.dir)
@ -693,16 +646,6 @@ function! s:update_serial(pull, todo)
call append(3, s:format_message(!error, name, result))
call s:update_progress(a:pull, len(done), bar, total)
endfor
let extended = s:extend(keys(todo))
if !empty(extended)
let todo = filter(extended, '!has_key(done, v:key)')
let total += len(todo)
call s:update_progress(a:pull, len(done), bar, total)
else
break
endif
endwhile
endfunction
function! s:update_parallel(pull, todo, threads)
@ -728,7 +671,6 @@ function! s:update_parallel(pull, todo, threads)
%["#{arg.gsub('"', '\"')}"]
end
require 'set'
require 'thread'
require 'fileutils'
require 'timeout'
@ -859,12 +801,8 @@ function! s:update_parallel(pull, todo, threads)
end
} if VIM::evaluate('s:mac_gui') == 1
processed = Set.new
progress = iswin ? '' : '--progress'
until all.empty?
names = all.keys
processed.merge names
[names.length, nthr].min.times do
[all.length, nthr].min.times do
mtx.synchronize do
threads << Thread.new {
while pair = take1.call
@ -908,14 +846,7 @@ function! s:update_parallel(pull, todo, threads)
end
end
threads.each { |t| t.join rescue nil }
mtx.synchronize { threads.clear }
extended = Hash[(VIM::evaluate("s:extend(#{names.inspect})") || {}).reject { |k, _|
processed.include? k
}]
tot += extended.length
all.merge!(extended)
logh.call
end
refresh.kill if refresh
watcher.kill
EOF

View File

@ -357,7 +357,8 @@ Execute (Trying to execute on-demand commands when plugin is not installed):
Execute (New set of plugins):
call plug#begin()
Plug 'junegunn/vim-fnr' " Depends on vim-pseudocl
Plug 'junegunn/vim-fnr'
Plug 'junegunn/vim-pseudocl'
Plug 'junegunn/vim-easy-align', { 'on': 'EasyAlign' }
Plug 'junegunn/vim-redis', { 'for': 'redis' }
call plug#end()
@ -368,15 +369,15 @@ Execute (Check commands):
Execute (Partial PlugInstall):
PlugInstall vim-fnr vim-easy-align
AssertExpect 'vim-pseudocl', 1
PlugInstall vim-fnr vim-easy-align 1
AssertExpect 'vim-pseudocl', 1
AssertExpect 'vim-fnr', 1
q
Execute (Check dependent plugin):
Assert &rtp =~ 'pseudocl', &rtp
PlugInstall vim-fnr vim-easy-align 1
AssertExpect 'vim-fnr', 1
AssertExpect 'vim-easy-align', 1
AssertEqual first_rtp, split(&rtp, ',')[0]
AssertEqual last_rtp, split(&rtp, ',')[-1]
q
Given (Unaligned code):
a=1
@ -668,6 +669,7 @@ Execute (Using Funcref):
Execute (Using custom dir):
Assert isdirectory(g:plugs['vim-easy-align'].dir)
call system('rm -rf '.$TMPDIR.'easy-align')
call plug#begin()
Plug 'junegunn/vim-easy-align', { 'dir': $TMPDIR.'easy-align' }
call plug#end()